Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3688] An extra admin variables tab for registration variables #3990

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Mar 8, 2024

Part of #3688.

Backend part: #3984

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.02%. Comparing base (50ff077) to head (50270c0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3990   +/-   ##
=======================================
  Coverage   96.02%   96.02%           
=======================================
  Files         728      728           
  Lines       22786    22786           
  Branches     2634     2634           
=======================================
  Hits        21881    21881           
  Misses        649      649           
  Partials      256      256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Viicos Viicos force-pushed the feature/3688-registration-variables-frontend branch from 38210cb to d3da1a7 Compare March 15, 2024 09:56
@Viicos Viicos force-pushed the feature/3688-registration-variables-frontend branch from d3da1a7 to 50270c0 Compare March 15, 2024 10:23
@Viicos Viicos requested a review from sergei-maertens March 15, 2024 10:46

const headColumns = (
<>
<HeadColumn content="" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this unused columns leads to styling issues

@Viicos Viicos merged commit a940355 into master Mar 15, 2024
22 checks passed
@Viicos Viicos deleted the feature/3688-registration-variables-frontend branch March 15, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants