Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3688] Add Objecttypes API endpoints #3895

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Feb 15, 2024

Part of #3688

This is the one that was already reviewed and merged back in the original PR.

@Viicos Viicos linked an issue Feb 15, 2024 that may be closed by this pull request
33 tasks
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e56ce00) 96.34% compared to head (d7a2d80) 96.35%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3895   +/-   ##
=======================================
  Coverage   96.34%   96.35%           
=======================================
  Files         708      711    +3     
  Lines       22213    22250   +37     
  Branches     2550     2554    +4     
=======================================
+ Hits        21401    21438   +37     
  Misses        565      565           
  Partials      247      247           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaszig vaszig assigned vaszig and unassigned vaszig Feb 16, 2024
@vaszig
Copy link
Contributor

vaszig commented Feb 16, 2024

I am a bit confused with this..What do you mean it's already reviewed and merged?

@Viicos
Copy link
Contributor Author

Viicos commented Feb 16, 2024

It was a mess but this PR is the same as #3860, which was merged back into a closed PR (can be seen by looking at the target branch)

@sergei-maertens sergei-maertens merged commit 0213cca into master Feb 16, 2024
27 checks passed
@sergei-maertens sergei-maertens deleted the feature/3688-objecttypes-api-endpoints-2 branch February 16, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Objects API registration backend - Improve JSON content field / mapping editor
3 participants