Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3688] Implement Objecttypes client #3883

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Feb 14, 2024

Supersedes #3847

@Viicos Viicos force-pushed the feature/3688-phase1-objecttypes-client branch 2 times, most recently from 8c29618 to 2016f3c Compare February 14, 2024 15:09
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d3ce2c2) 96.34% compared to head (8c29618) 96.34%.

❗ Current head 8c29618 differs from pull request most recent head 2016f3c. Consider uploading reports for the commit 2016f3c to get more accurate results

Files Patch % Lines
...enforms/contrib/objects_api/clients/objecttypes.py 91.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3883      +/-   ##
==========================================
- Coverage   96.34%   96.34%   -0.01%     
==========================================
  Files         707      708       +1     
  Lines       22189    22213      +24     
  Branches     2547     2550       +3     
==========================================
+ Hits        21379    21401      +22     
  Misses        565      565              
- Partials      245      247       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaszig vaszig self-assigned this Feb 15, 2024
@sergei-maertens sergei-maertens merged commit e56ce00 into master Feb 15, 2024
25 of 27 checks passed
@sergei-maertens sergei-maertens deleted the feature/3688-phase1-objecttypes-client branch February 15, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Objects API registration backend - Improve JSON content field / mapping editor
3 participants