Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2762] update settings: log outgoing requests #3074

Merged
merged 5 commits into from
Jun 9, 2023

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented May 10, 2023

Closes #2762 (partly)
Depends on maykinmedia/django-log-outgoing-requests

  • add settings for saving request & response body
  • add celery task + schedule for cleaning up logs

image

@pi-sigma pi-sigma force-pushed the feature/2762-request-logging branch 2 times, most recently from 6983809 to 4f7e92e Compare May 10, 2023 08:22
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (3681101) 94.34% compared to head (c579a31) 94.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3074      +/-   ##
==========================================
+ Coverage   94.34%   94.36%   +0.01%     
==========================================
  Files         610      611       +1     
  Lines       19007    19047      +40     
  Branches     2163     2163              
==========================================
+ Hits        17933    17973      +40     
  Misses        783      783              
  Partials      291      291              
Impacted Files Coverage Δ
src/log_outgoing_requests_ext/tasks.py 100.00% <100.00%> (ø)
src/openforms/conf/base.py 90.86% <100.00%> (+0.28%) ⬆️
src/openforms/conf/ci.py 100.00% <100.00%> (ø)
src/openforms/conf/dev.py 84.78% <100.00%> (+0.33%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pi-sigma
Copy link
Contributor Author

The error in log_outgoing_requests/log_requests.py, line 24 is caused by a name conflict that's fixed by the complement PR in maykinmedia/django-log-outgoing-requests

@pi-sigma pi-sigma force-pushed the feature/2762-request-logging branch from 4f7e92e to 931b7eb Compare May 10, 2023 09:07
@pi-sigma pi-sigma marked this pull request as ready for review May 10, 2023 10:03
@pi-sigma pi-sigma force-pushed the feature/2762-request-logging branch 3 times, most recently from b591a8a to f754140 Compare May 17, 2023 14:42
@pi-sigma pi-sigma force-pushed the feature/2762-request-logging branch from f754140 to 4920b84 Compare May 31, 2023 07:09
@sergei-maertens sergei-maertens self-assigned this Jun 8, 2023
@sergei-maertens sergei-maertens force-pushed the feature/2762-request-logging branch 4 times, most recently from 2ba2b72 to ed255f5 Compare June 8, 2023 20:48
@sergei-maertens
Copy link
Member

Styling for JSON without newlines is not great yet:

image

@sergei-maertens sergei-maertens force-pushed the feature/2762-request-logging branch from 853577d to 1c9a74d Compare June 9, 2023 10:35
When the content is too wide, with float it wraps onto the next line. Using
flexbox ensures this doesn't happen.
@sergei-maertens sergei-maertens force-pushed the feature/2762-request-logging branch from 1c9a74d to c579a31 Compare June 9, 2023 11:29
@sergei-maertens sergei-maertens merged commit 5d0a3b8 into master Jun 9, 2023
@sergei-maertens sergei-maertens deleted the feature/2762-request-logging branch June 9, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logging in the admin to see outgoing requests/responses
2 participants