[#3718] PR feedback

open-formulieren · Mar 13, 2024 · f32dc67 · f32dc67
1 parent 2603fa8
commit f32dc67
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/src/openforms/forms/api/serializers/form_definition.py b/src/openforms/forms/api/serializers/form_definition.py
@@ -161,14 +161,6 @@ def validate(self, attrs):
 
         return attrs
 
-    def save(self, **kwargs):
-        # field 'component_translations' has been deprecated and it's not part of
-        # the 'form_definition' model anymore. We use it only in the serializer.
-        if "component_translations" in self.validated_data:
-            del self.validated_data["component_translations"]
-
-        return super().save(**kwargs)
-
 
 class FormDefinitionDetailSerializer(FormDefinitionSerializer):
     used_in = UsedInFormSerializer(

diff --git a/src/openforms/forms/utils.py b/src/openforms/forms/utils.py
@@ -313,6 +313,11 @@ def import_form_data(
                         deserialized.validated_data["configuration"]
                     )
 
+                    # field 'component_translations' has been deprecated and it's not part of
+                    # the 'form_definition' model anymore. We use it only in the serializer.
+                    if "component_translations" in deserialized.validated_data:
+                        del deserialized.validated_data["component_translations"]
+
                 if resource == "formLogic":
                     clear_old_service_fetch_config(deserialized.validated_data)