Merge pull request #4003 from open-formulieren/issue/objects-api-chec…

…k-config

Fix config checks for Objects API plugin

src/openforms/registrations/contrib/objects_api/checks.py

@@ -15,17 +15,24 @@
 
 def check_objects_service():
     with get_objects_client() as client:
-        client.get("objects", params={"pageSize": 1})
+        resp = client.get("objects", params={"pageSize": 1})
+        resp.raise_for_status()
+        if not 200 <= resp.status_code < 300:
+            raise InvalidPluginConfiguration(_("Missing API credentials"))
 
 
 def check_objecttypes_service():
     with get_objecttypes_client() as client:
-        client.get("objecttypes", params={"pageSize": 1})
+        resp = client.get("objecttypes", params={"pageSize": 1})
+        resp.raise_for_status()
+        if not 200 <= resp.status_code < 300:
+            raise InvalidPluginConfiguration(_("Missing API credentials"))
 
 
 def check_documents_service():
     with get_documents_client() as client:
-        client.get("enkelvoudiginformatieobjecten")
+        resp = client.get("enkelvoudiginformatieobjecten")
+        resp.raise_for_status()
 
 
 def check_config():

src/openforms/registrations/contrib/objects_api/tests/test_config_checks.py

@@ -77,7 +77,7 @@ def test_no_objecttypes_service_configured(self, m: requests_mock.Mocker):
             plugin.check_config()
 
     @requests_mock.Mocker()
-    def test_objects_service_misconfigured(self, m):
+    def test_objects_service_misconfigured_connection_error(self, m):
         m.get(
             "https://objects.example.com/api/v1/objects?pageSize=1",
             exc=requests.ConnectionError,
@@ -87,6 +87,43 @@ def test_objects_service_misconfigured(self, m):
         with self.assertRaises(InvalidPluginConfiguration):
             plugin.check_config()
 
+    @requests_mock.Mocker()
+    def test_objects_service_misconfigured_http_error(self, m):
+        m.get(
+            "https://objects.example.com/api/v1/objects?pageSize=1",
+            status_code=400,
+        )
+        plugin = ObjectsAPIRegistration(PLUGIN_IDENTIFIER)
+
+        with self.assertRaises(InvalidPluginConfiguration):
+            plugin.check_config()
+
+    @requests_mock.Mocker()
+    def test_objects_service_misconfigured_redirect(self, m):
+        m.get(
+            "https://objects.example.com/api/v1/objects?pageSize=1",
+            status_code=302,
+        )
+        plugin = ObjectsAPIRegistration(PLUGIN_IDENTIFIER)
+
+        with self.assertRaises(InvalidPluginConfiguration):
+            plugin.check_config()
+
+    @requests_mock.Mocker()
+    def test_objecttypes_service_misconfigured_redirect(self, m):
+        m.get(
+            "https://objects.example.com/api/v1/objects?pageSize=1",
+            json={"results": []},
+        )
+        m.get(
+            "https://objecttypes.example.com/api/v1/objecttypes?pageSize=1",
+            status_code=302,
+        )
+        plugin = ObjectsAPIRegistration(PLUGIN_IDENTIFIER)
+
+        with self.assertRaises(InvalidPluginConfiguration):
+            plugin.check_config()
+
     @requests_mock.Mocker()
     def test_no_documents_service_configured(self, m):
         self.config.drc_service = None