Merge pull request #4607 from open-formulieren/feature/4606-improve-z…

…gw-registration-options-ux Convert ZGW registration options to modal + Formik
open-formulieren · Aug 19, 2024 · d46319d · d46319d
2 parents e8e588d + df4ecee
commit d46319d
Show file tree

Hide file tree

Showing 31 changed files with 1,433 additions and 1,306 deletions.
diff --git a/src/openforms/forms/tests/e2e_tests/test_registration_backend_conf.py b/src/openforms/forms/tests/e2e_tests/test_registration_backend_conf.py
@@ -121,7 +121,14 @@ def collect_requests(request):
                 await page.get_by_role(
                     "combobox", name="Select registration backend"
                 ).select_option(label="ZGW API's")
-                await page.get_by_label("ZGW API group").select_option(label="Group 1")
+                await page.get_by_role("button", name="Configure options").click()
+
+                config_modal = page.get_by_role("dialog")
+                await rs_select_option(
+                    config_modal.get_by_role("combobox", name="API group"),
+                    option_label="Group 1",
+                )
+                await config_modal.get_by_role("button", name="Save").click()
 
             with phase("Configure upload component"):
                 await page.get_by_role("tab", name="Steps and fields").click()
@@ -132,10 +139,14 @@ def collect_requests(request):
 
             with phase("Update the ZGW API group configured"):
                 await page.get_by_role("tab", name="Registration").click()
-                await page.get_by_role(
-                    "combobox", name="Select registration backend"
-                ).select_option(label="ZGW API's")
-                await page.get_by_label("ZGW API group").select_option(label="Group 2")
+                await page.get_by_role("button", name="Configure options").click()
+
+                config_modal = page.get_by_role("dialog")
+                await rs_select_option(
+                    config_modal.get_by_role("combobox", name="API group"),
+                    option_label="Group 2",
+                )
+                await config_modal.get_by_role("button", name="Save").click()
 
             with phase("Reopen the upload component"):
                 await page.get_by_role("tab", name="Steps and fields").click()