[#3470] Slugify form name in pdf submission reports

Backport-of: #3480

requirements/ci.txt

@@ -459,7 +459,7 @@ humanize==3.14.0
     #   -c requirements/base.txt
     #   -r requirements/base.txt
     #   flower
-hypothesis==6.58.0
+hypothesis==6.84.3
     # via -r requirements/test-tools.in
 idna==2.10
     # via

requirements/dev.txt

@@ -520,7 +520,7 @@ humanize==3.14.0
     #   -c requirements/ci.txt
     #   -r requirements/ci.txt
     #   flower
-hypothesis==6.58.0
+hypothesis==6.84.3
     # via
     #   -c requirements/ci.txt
     #   -r requirements/ci.txt

src/openforms/submissions/models/submission_report.py

@@ -73,7 +73,7 @@ def generate_submission_report_pdf(self) -> str:
             )
             self.content = ContentFile(
                 content=pdf_report,
-                name=f"{form.name}.pdf",  # Takes care of replacing spaces with underscores
+                name=f"{form.slug}.pdf",
             )
         self.save()
         return html_report

src/openforms/submissions/tests/test_models.py

@@ -3,8 +3,10 @@
 from unittest.mock import patch
 
 from django.core.exceptions import ValidationError
-from django.test import TestCase, override_settings
+from django.test import TestCase, override_settings, tag
 
+from hypothesis import given, settings, strategies as st
+from hypothesis.extra.django import TestCase as HypothesisTestCase
 from privates.test import temp_private_root
 from testfixtures import LogCapture
 
@@ -19,6 +21,7 @@
 from .factories import (
     SubmissionFactory,
     SubmissionFileAttachmentFactory,
+    SubmissionReportFactory,
     SubmissionStepFactory,
 )
 
@@ -617,3 +620,20 @@ def test_clear_execution_state_without_execution_state(self):
         self.assertFalse(hasattr(submission, "_execution_state"))
 
         submission.clear_execution_state()
+
+
+@temp_private_root()
+class PDFSubmissionReportTests(HypothesisTestCase):
+    @tag("gh-3470")
+    @given(
+        st.text(
+            min_size=1,
+            alphabet=st.characters(blacklist_characters="\x00", codec="utf-8"),
+        )
+    )
+    @settings(deadline=500)
+    def test_names_do_not_break_pdf_saving_to_disk(self, form_name):
+        report = SubmissionReportFactory.create(submission__form__name=form_name)
+        report.generate_submission_report_pdf()
+
+        self.assertTrue(report.content.storage.exists(report.content.name))

src/openforms/submissions/tests/test_submission_report.py

@@ -89,15 +89,17 @@ def test_invalid_token_timestamp(self):
 
     @patch("celery.app.task.Task.request")
     def test_report_generation(self, mock_request):
-        submission = SubmissionFactory.create(completed=True, form__name="Test Form")
+        submission = SubmissionFactory.create(
+            completed=True, form__name="Test Form", form__slug="test-form"
+        )
         mock_request.id = "some-id"
 
         generate_submission_report(submission.id)
 
         report = submission.report
         self.assertEqual("some-id", report.task_id)
         # report.content.name contains the path too
-        self.assertTrue(report.content.name.endswith("Test_Form.pdf"))
+        self.assertTrue(report.content.name.endswith("test-form.pdf"))
 
     def test_report_is_generated_in_same_language_as_submission(self):
         # fixture_data

src/openforms/submissions/tests/test_tasks_pdf.py

@@ -16,7 +16,9 @@
 @temp_private_root()
 class SubmissionReportGenerationTests(TestCase):
     def test_submission_report_metadata(self):
-        submission = SubmissionFactory.create(completed=True, form__name="Test Form")
+        submission = SubmissionFactory.create(
+            completed=True, form__name="Test Form", form__slug="test-form"
+        )
 
         generate_submission_report.request.id = "some-id"
         generate_submission_report.run(submission.id)
@@ -26,7 +28,7 @@ def test_submission_report_metadata(self):
             _("%(title)s: Submission report") % {"title": "Test Form"}, report.title
         )
         self.assertEqual(submission, report.submission)
-        self.assertTrue(report.content.name.endswith("Test_Form.pdf"))
+        self.assertTrue(report.content.name.endswith("test-form.pdf"))
         self.assertEqual("some-id", report.task_id)
 
     def test_multiple_value_report_rendering_issue_990(self):