Skip to content

Commit

Permalink
[#3890] PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
vaszig committed Feb 27, 2024
1 parent 0cd4123 commit 6668d73
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions src/openforms/formio/rendering/nodes.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ def is_visible(self) -> bool:
from .default import EditGridGroupNode

# everything is emitted in export mode to get consistent columns
if self.mode == RenderModes.export:
# the same happens with the registration in order to include hidden fields as well
if self.mode in {RenderModes.export, RenderModes.registration}:
return True

# explicitly hidden components never show up. Note that this property can be set
Expand All @@ -143,9 +144,7 @@ def is_visible(self) -> bool:
self.component, artificial_repeating_group_data
):
return False
elif self.mode != RenderModes.registration and not is_visible_in_frontend(
self.component, self.step_data
):
elif not is_visible_in_frontend(self.component, self.step_data):
return False

render_configuration = RENDER_CONFIGURATION[self.mode]
Expand Down

0 comments on commit 6668d73

Please sign in to comment.