Skip to content

Commit

Permalink
✅ [#2173] Added tests for map component
Browse files Browse the repository at this point in the history
  • Loading branch information
@robinmolen
robinmolen committed Dec 9, 2024
1 parent f94477f commit 5b507f9
Show file tree
Hide file tree
Showing 3 changed files with 270 additions and 1 deletion.
9 changes: 9 additions & 0 deletions src/openforms/config/tests/factories.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,12 @@ class ThemeFactory(factory.django.DjangoModelFactory):

class Meta:
model = "config.Theme"


class MapTileLayerFactory(factory.django.DjangoModelFactory):
identifier = factory.Faker("word")
url = factory.Sequence(lambda n: f"http://example-{n}.com")
label = factory.Faker("word")

class Meta:
model = "config.MapTileLayer"
23 changes: 22 additions & 1 deletion src/openforms/config/tests/test_admin.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

from openforms.accounts.tests.factories import SuperUserFactory

from .factories import RichTextColorFactory
from .factories import MapTileLayerFactory, RichTextColorFactory


@disable_admin_mfa()
Expand All @@ -27,3 +27,24 @@ def test_color_detail(self):
response = self.app.get(url, user=user)

self.assertEqual(response.status_code, 200)


@disable_admin_mfa()
class MapTileLayerTests(WebTest):
def test_map_tile_layer_changelist(self):
MapTileLayerFactory.create_batch(9)
url = reverse("admin:config_maptilelayer_changelist")
user = SuperUserFactory.create()

response = self.app.get(url, user=user)

self.assertEqual(response.status_code, 200)

def test_map_tile_layer_detail(self):
map = MapTileLayerFactory.create()
url = reverse("admin:config_maptilelayer_change", args=(map.pk,))
user = SuperUserFactory.create()

response = self.app.get(url, user=user)

self.assertEqual(response.status_code, 200)
239 changes: 239 additions & 0 deletions src/openforms/formio/tests/test_rewrite_for_request.py
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,239 @@
from unittest.mock import Mock, patch

from django.test import TestCase

from rest_framework.test import APIRequestFactory

from openforms.config.models import GlobalConfiguration
from openforms.config.tests.factories import MapTileLayerFactory
from openforms.formio.components.custom import Map
from openforms.formio.registry import ComponentRegistry

rf = APIRequestFactory()


class RewriteForRequestTests(TestCase):
@patch("openforms.formio.components.vanilla.GlobalConfiguration.get_solo")
def test_map_without_use_config_default_map_settings(self, m_solo: Mock):
m_solo.return_value = GlobalConfiguration(
form_map_default_zoom_level="8",
form_map_default_latitude="55.123",
form_map_default_longitude="56.456",
)

component = {
"type": "map",
"defaultZoom": "3",
"initialCenter": {
"lat": "43.23",
"lng": "41.23",
},
"useConfigDefaultMapSettings": False,
}

register = ComponentRegistry()
register("map")(Map)
request = rf.get("/dummy")
register.update_config_for_request(component, request)

expected = {
"type": "map",
"defaultZoom": "3",
"initialCenter": {
"lat": "43.23",
"lng": "41.23",
},
"useConfigDefaultMapSettings": False,
}
self.assertEqual(component, expected)

@patch("openforms.formio.components.vanilla.GlobalConfiguration.get_solo")
def test_map_with_use_config_default_map_settings(self, m_solo: Mock):
m_solo.return_value = GlobalConfiguration(
form_map_default_zoom_level="8",
form_map_default_latitude="55.123",
form_map_default_longitude="56.456",
)

component = {
"type": "map",
"defaultZoom": "3",
"initialCenter": {
"lat": "43.23",
"lng": "41.23",
},
"useConfigDefaultMapSettings": True,
}

register = ComponentRegistry()
register("map")(Map)
request = rf.get("/dummy")
register.update_config_for_request(component, request)

expected = {
"type": "map",
"defaultZoom": "8",
"initialCenter": {
"lat": "55.123",
"lng": "56.456",
},
"useConfigDefaultMapSettings": True,
}
self.assertEqual(component, expected)

def test_map_without_tile_layer_identifier(self):
component = {
"type": "map",
"defaultZoom": "3",
"initialCenter": {
"lat": "43.23",
"lng": "41.23",
},
"useConfigDefaultMapSettings": False,
"tileLayerIdentifier": None,
}

register = ComponentRegistry()
register("map")(Map)
request = rf.get("/dummy")
register.update_config_for_request(component, request)

expected = {
"type": "map",
"defaultZoom": "3",
"initialCenter": {
"lat": "43.23",
"lng": "41.23",
},
"useConfigDefaultMapSettings": False,
"tileLayerIdentifier": None,
}
self.assertEqual(component, expected)

def test_map_with_invalid_tile_layer_identifier(self):
component = {
"type": "map",
"defaultZoom": "3",
"initialCenter": {
"lat": "43.23",
"lng": "41.23",
},
"useConfigDefaultMapSettings": False,
"tileLayerIdentifier": "",
}

register = ComponentRegistry()
register("map")(Map)
request = rf.get("/dummy")
register.update_config_for_request(component, request)

expected = {
"type": "map",
"defaultZoom": "3",
"initialCenter": {
"lat": "43.23",
"lng": "41.23",
},
"useConfigDefaultMapSettings": False,
"tileLayerIdentifier": "",
}
self.assertEqual(component, expected)

def test_map_with_valid_unknown_tile_layer_identifier(self):
component = {
"type": "map",
"defaultZoom": "3",
"initialCenter": {
"lat": "43.23",
"lng": "41.23",
},
"useConfigDefaultMapSettings": False,
"tileLayerIdentifier": "identifier",
}

register = ComponentRegistry()
register("map")(Map)
request = rf.get("/dummy")
register.update_config_for_request(component, request)

expected = {
"type": "map",
"defaultZoom": "3",
"initialCenter": {
"lat": "43.23",
"lng": "41.23",
},
"useConfigDefaultMapSettings": False,
"tileLayerIdentifier": "identifier",
}
self.assertEqual(component, expected)

def test_map_with_valid_known_tile_layer_identifier(self):
map = MapTileLayerFactory.create(identifier="identifier")
component = {
"type": "map",
"defaultZoom": "3",
"initialCenter": {
"lat": "43.23",
"lng": "41.23",
},
"useConfigDefaultMapSettings": False,
"tileLayerIdentifier": "identifier",
}

register = ComponentRegistry()
register("map")(Map)
request = rf.get("/dummy")
register.update_config_for_request(component, request)

expected = {
"type": "map",
"defaultZoom": "3",
"initialCenter": {
"lat": "43.23",
"lng": "41.23",
},
"useConfigDefaultMapSettings": False,
"tileLayerIdentifier": "identifier",
"tileLayerUrl": map.url,
}
self.assertEqual(component, expected)

@patch("openforms.formio.components.vanilla.GlobalConfiguration.get_solo")
def test_map_with_valid_known_tile_layer_identifier_and_use_config_default_map_settings(
self, m_solo: Mock
):
m_solo.return_value = GlobalConfiguration(
form_map_default_zoom_level="8",
form_map_default_latitude="55.123",
form_map_default_longitude="56.456",
)
map = MapTileLayerFactory.create(identifier="identifier")
component = {
"type": "map",
"defaultZoom": "3",
"initialCenter": {
"lat": "43.23",
"lng": "41.23",
},
"useConfigDefaultMapSettings": True,
"tileLayerIdentifier": "identifier",
}

register = ComponentRegistry()
register("map")(Map)
request = rf.get("/dummy")
register.update_config_for_request(component, request)

expected = {
"type": "map",
"defaultZoom": "8",
"initialCenter": {
"lat": "55.123",
"lng": "56.456",
},
"useConfigDefaultMapSettings": True,
"tileLayerIdentifier": "identifier",
"tileLayerUrl": map.url,
}
self.assertEqual(component, expected)

0 comments on commit 5b507f9

Please sign in to comment.