👌 [#3443] PR Feedback

open-formulieren · Sep 20, 2023 · 563db37 · 563db37
1 parent 549afa1
commit 563db37
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/src/openforms/forms/migrations/0093_date_component_settings.py b/src/openforms/forms/migrations/0093_date_component_settings.py
@@ -21,8 +21,8 @@ def add_date_component_settings(apps, schema_editor):
                         translated_errors[language_code]["minDate"] = ""
                         translated_errors[language_code]["maxDate"] = ""
 
-                custom_options = comp.get("customOptions", {})
-                custom_options["allowInvalidPreload"] = True
+                comp.setdefault("customOptions", {})
+                comp["customOptions"]["allowInvalidPreload"] = True
 
                 form_definitions_to_update.append(form_definition)
 

diff --git a/src/openforms/forms/tests/test_migrations.py b/src/openforms/forms/tests/test_migrations.py
@@ -80,7 +80,16 @@ def setUpBeforeMigration(self, apps):
                             "en": {"required": ""},
                             "nl": {"required": ""},
                         },
-                    }
+                    },
+                    {
+                        "key": "anotherDateComponent",
+                        "type": "date",
+                        "label": "Another Date component",
+                        "translatedErrors": {
+                            "en": {"required": ""},
+                            "nl": {"required": ""},
+                        },
+                    },
                 ]
             },
         )
@@ -112,3 +121,8 @@ def test_new_settings(self):
                 "allowInvalidPreload"
             ]
         )
+        self.assertTrue(
+            self.form_def.configuration["components"][1]["customOptions"][
+                "allowInvalidPreload"
+            ]
+        )