[#3470] Slugify form name in pdf submission reports

Backport-of: #3480

src/openforms/forms/tests/admin/test_form.py

@@ -5,7 +5,7 @@
 
 from django.apps import apps
 from django.contrib import admin
-from django.test import RequestFactory, TestCase, override_settings
+from django.test import RequestFactory, TestCase, override_settings, tag
 from django.urls import reverse
 from django.utils.module_loading import import_string
 from django.utils.translation import ugettext as _

src/openforms/submissions/models/submission_report.py

@@ -72,7 +72,7 @@ def generate_submission_report_pdf(self) -> str:
         )
         self.content = ContentFile(
             content=pdf_report,
-            name=f"{form.name}.pdf",  # Takes care of replacing spaces with underscores
+            name=f"{form.slug}.pdf",
         )
         self.save()
         return html_report

src/openforms/submissions/tests/test_submission_report.py

@@ -87,15 +87,17 @@ def test_invalid_token_timestamp(self):
 
     @patch("celery.app.task.Task.request")
     def test_report_generation(self, mock_request):
-        submission = SubmissionFactory.create(completed=True, form__name="Test Form")
+        submission = SubmissionFactory.create(
+            completed=True, form__name="Test Form", form__slug="test-form"
+        )
         mock_request.id = "some-id"
 
         generate_submission_report(submission.id)
 
         report = submission.report
         self.assertEqual("some-id", report.task_id)
         # report.content.name contains the path too
-        self.assertTrue(report.content.name.endswith("Test_Form.pdf"))
+        self.assertTrue(report.content.name.endswith("test-form.pdf"))
 
     @patch(
         "celery.result.AsyncResult._get_task_meta", return_value={"status": "SUCCESS"}

src/openforms/submissions/tests/test_tasks_pdf.py

@@ -15,7 +15,9 @@
 @temp_private_root()
 class SubmissionReportGenerationTests(TestCase):
     def test_submission_report_metadata(self):
-        submission = SubmissionFactory.create(completed=True, form__name="Test Form")
+        submission = SubmissionFactory.create(
+            completed=True, form__name="Test Form", form__slug="test-form"
+        )
 
         generate_submission_report.request.id = "some-id"
         generate_submission_report.run(submission.id)
@@ -25,7 +27,7 @@ def test_submission_report_metadata(self):
             _("%(title)s: Submission report") % {"title": "Test Form"}, report.title
         )
         self.assertEqual(submission, report.submission)
-        self.assertTrue(report.content.name.endswith("Test_Form.pdf"))
+        self.assertTrue(report.content.name.endswith("test-form.pdf"))
         self.assertEqual("some-id", report.task_id)
 
     def test_multiple_value_report_rendering_issue_990(self):