feat: add grace period option

Signed-off-by: Bernd Warmuth <[email protected]>
open-feature · Jan 3, 2025 · bc06454 · bc06454
1 parent 334b5c2
commit bc06454
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/Config.java b/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/Config.java
@@ -18,6 +18,7 @@ public final class Config {
 
     static final int DEFAULT_DEADLINE = 500;
     static final int DEFAULT_STREAM_DEADLINE_MS = 10 * 60 * 1000;
+    static final int DEFAULT_STREAM_RETRY_GRACE_PERIOD = 50_000;
     static final int DEFAULT_MAX_CACHE_SIZE = 1000;
     static final long DEFAULT_KEEP_ALIVE = 0;
 
@@ -38,6 +39,7 @@ public final class Config {
     static final String KEEP_ALIVE_MS_ENV_VAR_NAME_OLD = "FLAGD_KEEP_ALIVE_TIME";
     static final String KEEP_ALIVE_MS_ENV_VAR_NAME = "FLAGD_KEEP_ALIVE_TIME_MS";
     static final String TARGET_URI_ENV_VAR_NAME = "FLAGD_TARGET_URI";
+    static final String STREAM_RETRY_GRACE_PERIOD = "FLAGD_RETRY_GRACE_PERIOD_MS";
 
     static final String RESOLVER_RPC = "rpc";
     static final String RESOLVER_IN_PROCESS = "in-process";
@@ -55,7 +57,7 @@ public final class Config {
     public static final String LRU_CACHE = CacheType.LRU.getValue();
     static final String DEFAULT_CACHE = LRU_CACHE;
 
-    static final int DEFAULT_MAX_EVENT_STREAM_RETRIES = 5;
+    static final int DEFAULT_MAX_EVENT_STREAM_RETRIES = 7;
     static final int BASE_EVENT_STREAM_RETRY_BACKOFF_MS = 1000;
 
     static String fallBackToEnvOrDefault(String key, String defaultValue) {

diff --git a/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdOptions.java b/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdOptions.java
@@ -1,10 +1,5 @@
 package dev.openfeature.contrib.providers.flagd;
 
-import static dev.openfeature.contrib.providers.flagd.Config.fallBackToEnvOrDefault;
-import static dev.openfeature.contrib.providers.flagd.Config.fromValueProvider;
-
-import java.util.function.Function;
-
 import dev.openfeature.contrib.providers.flagd.resolver.process.storage.connector.Connector;
 import dev.openfeature.sdk.EvaluationContext;
 import dev.openfeature.sdk.ImmutableContext;
@@ -14,6 +9,11 @@
 import lombok.Builder;
 import lombok.Getter;
 
+import java.util.function.Function;
+
+import static dev.openfeature.contrib.providers.flagd.Config.fallBackToEnvOrDefault;
+import static dev.openfeature.contrib.providers.flagd.Config.fromValueProvider;
+
 /**
  * FlagdOptions is a builder to build flagd provider options.
  */
@@ -101,6 +101,12 @@ public class FlagdOptions {
     private int streamDeadlineMs = fallBackToEnvOrDefault(Config.STREAM_DEADLINE_MS_ENV_VAR_NAME,
             Config.DEFAULT_STREAM_DEADLINE_MS);
 
+    /**
+     * Amount of stream retry attempts before provider moves from STALE to ERROR
+     * Defaults to 5
+     */
+    @Builder.Default
+    private int streamRetryGracePeriod = fallBackToEnvOrDefault(Config.STREAM_RETRY_GRACE_PERIOD, Config.DEFAULT_STREAM_RETRY_GRACE_PERIOD);
     /**
      * Selector to be used with flag sync gRPC contract.
      **/