Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds intro #930

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Sep 22, 2023

  • fills out intro adding some questions.
    • not sure if we should add some simple diagrams here

Signed-off-by: Todd Baert <[email protected]>
@toddbaert toddbaert requested a review from beeme1mr September 22, 2023 14:14
@toddbaert toddbaert requested a review from a team as a code owner September 22, 2023 14:14
The flag definitions supplied to flagd (*sources*) are monitored for changes which will be immediately reflected in flagd's evaluations.
Currently supported sources include files, HTTP endpoints, Kubernetes custom resources, and proto-compliant gRPC services.

<!-- Should we add some simple diagrams here to illustrate the deployment options and sources? -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add a Grid section linking out the various deployment sections.

https://squidfunk.github.io/mkdocs-material/reference/grids

I wouldn't recommend adding an image here.

Copy link
Member Author

@toddbaert toddbaert Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will convert this comment into a TODO comment to link to the deployment scenario as you describe.

Signed-off-by: Todd Baert <[email protected]>
@toddbaert toddbaert merged commit c8ddb88 into chore/web-doc-rework Sep 22, 2023
2 of 4 checks passed
@toddbaert toddbaert deleted the chore/web-doc-rework-todd branch September 22, 2023 14:25
toddbaert added a commit that referenced this pull request Sep 22, 2023
* fills out intro adding some questions.
  * not sure if we should add some simple diagrams here

Signed-off-by: Todd Baert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants