Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support stricter type checking behavior as a Resolver configura… #1480

Closed
wants to merge 1 commit into from
Closed

feat: support stricter type checking behavior as a Resolver configura… #1480

wants to merge 1 commit into from

Conversation

cupofcat
Copy link

This PR

  • Adds ResolverConfiguration that can be set when creating a new JSON evaluator. Configuration can be used to set stricter flag variants type checking (a couple of flavors).

Follow-up Tasks

  • Changes to go-sdk-contrib flagd provider will be needed to take advantage of this new functionality
  • Adding flagd command line flags to enable this will be needed

@cupofcat cupofcat requested a review from a team as a code owner December 18, 2024 14:28
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 18, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 18, 2024 •
edited
Loading

✅ Deploy Preview for polite-licorice-3db33c canceled.

Name Link
🔨 Latest commit 3980d02
🔍 Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/6762dc0ba75aee0008ddbfc5

@cupofcat
Copy link
Author

This is a draft to gather early feedback. This PR needs to be extended with, at least, new tests to cover the new functionality.

@cupofcat
Copy link
Author

Apologies, I posted this too quickly. Let me close this for now and start at discussion on this new issue - #1481.

@cupofcat cupofcat closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cupofcat