feat: rework config gherkin file #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aepfli
force-pushed
the
feat/config-file-based-on-docs
branch
3 times, most recently
from
d0bf039 to
97f4e5e
Compare
The initial version of the gherkin file had some issues. It was not written in passive voice, and there have been no given states. Furthermore, it missed important fields from the flagd spec. Signed-off-by: Simon Schrottner <[email protected]>
aepfli
force-pushed
the
feat/config-file-based-on-docs
branch
from
97f4e5e to
e3aa2f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial version of the gherkin file had some issues. It was not written in passive voice, and there have been no given states.
Furthermore, it missed important fields from the flagd spec.
https://flagd.dev/reference/specifications/providers/#configuration-options