You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As discussed in #29, the collision and visual objects should be refactored and unified.
Arguments for collision and visual shapes should be unified (right now one uses half extents and the other full extents). Maybe they can even be combined to avoid code duplication.
Consistently use np.array instead of list everywhere for things like positions and orientations.
Make sure all object types follow the same API (right now, there is for example visual_objects.Marker which has not been touched in Use small Cuboid instead of Cube #29.
Add more functionality? (e.g. method to get velocity of a collision object)
The interfaces for collision and visual objects should really be unified, ideally even be merged in some way. I have not thought this through completely but maybe something like the following would be a good solution:
With this, the same "cube shape" object could be used for both the manipulation object and the goal marker, reducing the risk of accidentally defining them differently.
The text was updated successfully, but these errors were encountered:
As discussed in #29, the collision and visual objects should be refactored and unified.
np.array
instead oflist
everywhere for things like positions and orientations.visual_objects.Marker
which has not been touched in Use small Cuboid instead of Cube #29.Copy of my suggestion from #29:
The interfaces for collision and visual objects should really be unified, ideally even be merged in some way. I have not thought this through completely but maybe something like the following would be a good solution:
With this, the same "cube shape" object could be used for both the manipulation object and the goal marker, reducing the risk of accidentally defining them differently.
The text was updated successfully, but these errors were encountered: