Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add powerboard measurements to Solo12 sensor data #113

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

luator
Copy link
Member

@luator luator commented Apr 22, 2022

Description

open-dynamic-robot-initiative/master-board#98 Adds support for a separate power board that provides measurements of current, voltage and energy.
This PR adds the corresponding values to the sensor data of Solo12.

How I Tested

Running a dynamic_graph_head example and print the powerboard values there.

Do not merge before

  • Partial support of the new Power-Board hardware master-board#98
    (Note: It will still work without power board as well (the values will simply be zero if non is connected), but I am not sure if the firmware needs to be updated nonetheless to be compatible with SDK changes).
  • Corresponding PR on odri_control_interface (PR not yet created).

I fulfilled the following requirements

  • All new code is formatted according to our style guide (for C++ run clang-format, for Python, run flake8 and fix all warnings).
  • All new functions/classes are documented and existing documentation is updated according to changes.
  • No commented code from testing/debugging is kept (unless there is a good reason to keep it).

@jviereck
Copy link
Contributor

Thanks for adding this @luator.

I suggest we merge these changes once the power board change lands.

luator added 2 commits May 23, 2022 13:45
This enables power-board-related safety checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants