Some improvements of trifingerpro_post_submission #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still get false positives sometimes, so for now make a failing push sensor test *not* fail the whole self-test but add a flag `--fatal-push-sensor-test` so we can make it fatal without changing the code if we want.
So we can log the data to see how much the values drift over time.
This check recommends ternary operator instead of if-else-blocks but I find them much harder to read in Python, so disable this error.
Move push sensor test code to separate function.
Add a helper function `_move` to avoid code duplication on all the "move on min jerk trajectory" code blocks.
So we can change the threshold without needing to update the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It turned out that the new push sensor test still has frequent false positives (though fewer than before). So for now not fail the self-test due to push sensors by default but add flags to make the push sensor test fatal and also to change the threshold. This allows us to adapt the test on the system without need to update the code all the time.
The results of the push sensor test is now also always logged (independent of success or failure), so we can let it run for a while and then monitor how the test performs and also whether the push sensor values drift over time.
Further refactor a bit and add a flag to skip the camera tests (for faster testing).
How I Tested
By running it on one of the robots.