v1.0.6 #145
Closed
v1.0.6 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi guys, I would like to move on the release of this package. |
nim65s
requested changes
Dec 12, 2023
There was a problem hiding this comment.
Please don't make releases manually, we have jrl-cmakemodule helpers for this, and if we don't use those, process must be clearly documented.
Here, you at least forgot to change the end of the CHANGELOG.md file, plus this is lacking a PGP signed tag + a PGP signed release tarball
| @@ -6,6 +6,48 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ## [1.0.6] - 2023-11-15 | |||
|
|
|||
| - Change name of the package to make it release in ROS-2. | |||
There was a problem hiding this comment.
We can't change the name of a package in a minor version. We can release this package under a different name on ROS 2, but this is different.
There was a problem hiding this comment.
Sorry I should have remove this line because this PR does not change the package name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release 1.0.6 of the package
How I Tested
Tested on Linux and Mac
I fulfilled the following requirements