Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cmake #141

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Cmake #141

merged 4 commits into from
Oct 11, 2023

Conversation

nim65s
Copy link
Contributor

@nim65s nim65s commented Sep 25, 2023

Description

Update CMake use

How I Tested

Configured and compiled the project & ran tests

I fulfilled the following requirements

  • All new code is formatted according to our style guide (for C++ run clang-format, for Python, run flake8 and fix all warnings).
  • All new functions/classes are documented and existing documentation is updated according to changes.
  • No commented code from testing/debugging is kept (unless there is a good reason to keep it).

olivier-stasse
olivier-stasse approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@olivier-stasse olivier-stasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MaximilienNaveau
MaximilienNaveau approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@MaximilienNaveau MaximilienNaveau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good!

@MaximilienNaveau MaximilienNaveau merged commit 61bfc9a into master Oct 11, 2023
3 checks passed
@nim65s nim65s deleted the cmake branch October 11, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaximilienNaveau MaximilienNaveau MaximilienNaveau approved these changes

@olivier-stasse olivier-stasse olivier-stasse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nim65s @olivier-stasse @MaximilienNaveau