Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update compat #54

Merged
merged 1 commit into from
Feb 21, 2024
Merged

fix: update compat #54

merged 1 commit into from
Feb 21, 2024

Conversation

CefBoud
Copy link
Contributor

@CefBoud CefBoud commented Feb 20, 2024

This PR fixes integration tests failure on the master branch due to change introduced in this commit on edx-platform. The function derived_key was renamed to derive_key and moved. Its signature changed as well.

@CefBoud CefBoud force-pushed the CefBoud/BB-8594/fix-integration-tests branch from 27497c1 to a26febb Compare February 20, 2024 13:11
@CefBoud CefBoud requested a review from Agrendalath February 20, 2024 13:23
Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: checked that the CI is passing
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository: n/a

section_to_course/compat.py Outdated Show resolved Hide resolved
@CefBoud CefBoud force-pushed the CefBoud/BB-8594/fix-integration-tests branch from a26febb to 00692a6 Compare February 21, 2024 08:23
@CefBoud CefBoud merged commit 0a327a1 into main Feb 21, 2024
9 of 11 checks passed
@CefBoud CefBoud deleted the CefBoud/BB-8594/fix-integration-tests branch February 21, 2024 08:28
@CefBoud CefBoud mentioned this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants