Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send XBlock visibility status to the LMS #43

Conversation

Cup0fCoffee
Copy link
Member

Port of https://github.com/open-craft/frontend-app-learning/pull/35/files

TLDR: there are two commits that change how the completions are tracked - one in edx-platform and one in learning MFE. One doesn't work without the other. The client's instances are running edx-platform with the change (opencraft-release/redwood.1), but MFE without the change (asu-moe/redwood-css), so the completions are not being tracked correctly.

To test, make sure both are deployed, go to a course, and test that opening a subsection with HTML and Text XBlocks is marked completed after 5 seconds of being visible.

BB-9275

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.49%. Comparing base (cb1a614) to head (26da658).
Report is 5 commits behind head on asu-moe/redwood-css.

Files with missing lines Patch % Lines
...re/course/sequence/Unit/hooks/useIFrameBehavior.js 94.11% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           asu-moe/redwood-css      #43      +/-   ##
=======================================================
+ Coverage                88.77%   89.49%   +0.72%     
=======================================================
  Files                      306      306              
  Lines                     5256     5275      +19     
  Branches                  1336     1338       +2     
=======================================================
+ Hits                      4666     4721      +55     
+ Misses                     573      537      -36     
  Partials                    17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@xitij2000 xitij2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as clean cherry-pick of tested code.

@Cup0fCoffee Cup0fCoffee merged commit 8fa41ed into asu-moe/redwood-css Oct 31, 2024
6 checks passed
@xitij2000 xitij2000 deleted the maxim/bb-9275-backport-completion-in-the-learning-mfe-redwood branch November 6, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants