open release/palm.1/backport search #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Added Courseware Search container popover * chore: Added unit tests for CoursewareSearch and CoursewareSearchToggle * chore: Updated unit test for CourseTabsNavigation * chore: Partial coverage on Courseware Search Hooks * chore: Finished Courseware Search Hooks unit testing * fix: Fixed an overlook that caused a conditional hook * fix: Reduced bounce timeout on scroll/resize to 100ms * chore: Updated snapshots * chore: Moved @testing-library/react-hooks dep to DEV * chore: Minor adjustments on unit tests * chore: Fixed test issue
* feat: Add CoursewareSearchBar component * fix: lint * fix: Clarified component names and i18n description * test: Add more tests * fix: lint * fix: Made props in CoursewareSearchForm optional
CefBoud
force-pushed
the
Cefboud/open-release/palm.1/backport-search
branch
from
0b7fefb to
afff925
Compare
* feat: Added CoursewareSearchResults UI component * fix: Added conditional for undefined case instead of null * fix: Updated code to avoid mutation
CefBoud
force-pushed
the
Cefboud/open-release/palm.1/backport-search
branch
from
afff925 to
c9c93dc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## opencraft-release/palm.1 #3 +/- ##
===========================================================
Coverage ? 87.10%
===========================================================
Files ? 260
Lines ? 4467
Branches ? 1126
===========================================================
Hits ? 3891
Misses ? 556
Partials ? 20 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of new Search functionnality to Palm release.
Ref: BB-8088