Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a state property to Command #455

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Add a state property to Command #455

merged 1 commit into from
Jan 3, 2024

Conversation

gustavohenke
Copy link
Member

Title.
The intention is that this will make it easier to tell exactly where the command is. My idea is that it can be used for #433, since it might be necessary to make a distinction between a command that was never started, and everything else.

Also marked it a breaking change because I removed the #exited property, as #state supersedes it.
Booleans do a poor job sometimes :)

Most LOC in this PR are coming from moving a few tests around.

@gustavohenke gustavohenke requested a review from paescuj December 12, 2023 09:21
@gustavohenke gustavohenke added this to the v9 milestone Dec 12, 2023
@coveralls
Copy link

Coverage Status

coverage: 99.2% (+0.003%) from 99.197%
when pulling 212d579 on command-state
into 0c64306 on main.

@gustavohenke
Copy link
Member Author

happy new year 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants