Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(amt): adds execute support for authorization #94

Merged
merged 6 commits into from
Oct 31, 2023
Merged

feat(amt): adds execute support for authorization #94

merged 6 commits into from
Oct 31, 2023

Conversation

zaidusmani26
Copy link
Contributor

No description provided.

@matt-primrose matt-primrose mentioned this pull request Oct 10, 2023
Closed
11 tasks
@zaidusmani26 zaidusmani26 force-pushed the authorizationXmlStructs branch from 4351d83 to 57b5775 Compare October 17, 2023 20:38
@zaidusmani26 zaidusmani26 force-pushed the authorizationXmlStructs branch from 57b5775 to e666a56 Compare October 17, 2023 20:42
@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (e6a8df7) 74.97% compared to head (f0489f5) 74.34%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             v2.0      #94      +/-   ##
==========================================
- Coverage   74.97%   74.34%   -0.63%     
==========================================
  Files          61       61              
  Lines        1694     1688       -6     
==========================================
- Hits         1270     1255      -15     
- Misses        359      364       +5     
- Partials       65       69       +4
Files Coverage Δ
pkg/amt/authorization/service.go 60.46% <62.50%> (-23.21%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zaidusmani26 zaidusmani26 marked this pull request as ready for review October 26, 2023 15:42
matt-primrose
matt-primrose suggested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@matt-primrose matt-primrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please clean up the commented code and import statements and add tests for lines missing code coverage identified by codecov

@rsdmike rsdmike enabled auto-merge (squash) October 31, 2023 00:28
@rsdmike rsdmike requested a review from matt-primrose October 31, 2023 00:29
@rsdmike rsdmike merged commit 727ed7e into v2.0 Oct 31, 2023
5 of 7 checks passed
@rsdmike rsdmike deleted the authorizationXmlStructs branch October 31, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-primrose matt-primrose matt-primrose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zaidusmani26 @matt-primrose @rsdmike