Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(amt): add execute support for userinitiated #105

Merged
merged 8 commits into from
Oct 30, 2023
Merged

feat(amt): add execute support for userinitiated #105

merged 8 commits into from
Oct 30, 2023

Conversation

zaidusmani26
Copy link
Contributor

No description provided.

@zaidusmani26 zaidusmani26 mentioned this pull request Oct 16, 2023
Closed
11 tasks
@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v2.0@6ff49f2). Click here to learn what that means.

❗ Current head b183f38 differs from pull request most recent head d27f9c2. Consider uploading reports for the commit d27f9c2 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             v2.0     #105   +/-   ##
=======================================
  Coverage        ?   80.67%           
=======================================
  Files           ?       61           
  Lines           ?     1485           
  Branches        ?        0           
=======================================
  Hits            ?     1198           
  Misses          ?      249           
  Partials        ?       38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zaidusmani26 zaidusmani26 marked this pull request as ready for review October 26, 2023 15:44
matt-primrose
matt-primrose suggested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@matt-primrose matt-primrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please clean up the commented code and import statement and add tests for lines missing code coverage identified by codecov

@rsdmike rsdmike enabled auto-merge (squash) October 30, 2023 22:50
@rsdmike rsdmike merged commit 60dab36 into v2.0 Oct 30, 2023
@rsdmike rsdmike deleted the userXmlStructs branch October 30, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-primrose matt-primrose matt-primrose approved these changes

@rsdmike rsdmike rsdmike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zaidusmani26 @rsdmike @matt-primrose