Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amt): add execute support for setup #104

Merged
merged 8 commits into from
Oct 30, 2023
Merged

feat(amt): add execute support for setup #104

merged 8 commits into from
Oct 30, 2023

Conversation

zaidusmani26
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (60dab36) 76.37% compared to head (b9f3df9) 75.54%.

❗ Current head b9f3df9 differs from pull request most recent head fef0162. Consider uploading reports for the commit fef0162 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             v2.0     #104      +/-   ##
==========================================
- Coverage   76.37%   75.54%   -0.83%     
==========================================
  Files          61       61              
  Lines        1642     1660      +18     
==========================================
  Hits         1254     1254              
- Misses        330      345      +15     
- Partials       58       61       +3     
Files Coverage Δ
pkg/amt/setupandconfiguration/service.go 53.06% <56.81%> (-30.81%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zaidusmani26 zaidusmani26 marked this pull request as ready for review October 26, 2023 15:44
Copy link
Contributor

@matt-primrose matt-primrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please clean up the commented code and import statement and add test coverage for the lines identified by codecov.

@rsdmike rsdmike enabled auto-merge (squash) October 30, 2023 23:06
@rsdmike rsdmike requested a review from matt-primrose October 30, 2023 23:06
@rsdmike rsdmike merged commit fa7300c into v2.0 Oct 30, 2023
4 checks passed
@rsdmike rsdmike deleted the setupXmlStructs branch October 30, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants