Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(amt): add execute support for redirection #103

Merged
merged 6 commits into from
Oct 30, 2023
Merged

feat(amt): add execute support for redirection #103

merged 6 commits into from
Oct 30, 2023

Conversation

zaidusmani26
Copy link
Contributor

No description provided.

@zaidusmani26 zaidusmani26 mentioned this pull request Oct 16, 2023
Closed
11 tasks
@zaidusmani26 zaidusmani26 force-pushed the redirectionXmlStructs branch from f2c9fbd to f1173da Compare October 25, 2023 22:44
@zaidusmani26 zaidusmani26 force-pushed the redirectionXmlStructs branch from 6cab79d to 1c43ede Compare October 25, 2023 22:59
@rsdmike rsdmike force-pushed the redirectionXmlStructs branch from 1c43ede to 81a418f Compare October 26, 2023 16:21
@codecov
Copy link

codecov bot commented Oct 26, 2023 •
edited
Loading

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (fa7300c) 75.54% compared to head (7f8e8be) 74.97%.

❗ Current head 7f8e8be differs from pull request most recent head 525aba3. Consider uploading reports for the commit 525aba3 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             v2.0     #103      +/-   ##
==========================================
- Coverage   75.54%   74.97%   -0.58%     
==========================================
  Files          61       61              
  Lines        1660     1694      +34     
==========================================
+ Hits         1254     1270      +16     
- Misses        345      359      +14     
- Partials       61       65       +4
Files Coverage Δ
pkg/amt/redirection/service.go 54.16% <59.09%> (-17.27%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zaidusmani26 zaidusmani26 marked this pull request as ready for review October 26, 2023 16:30
matt-primrose
matt-primrose suggested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@matt-primrose matt-primrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean up commented code and add tests to cover the lines that are missing code coverage

@zaidusmani26 zaidusmani26 force-pushed the redirectionXmlStructs branch from 81a418f to 6a2dff2 Compare October 30, 2023 23:03
@rsdmike rsdmike requested a review from matt-primrose October 30, 2023 23:22
@rsdmike rsdmike enabled auto-merge (squash) October 30, 2023 23:23
@rsdmike rsdmike merged commit e6a8df7 into v2.0 Oct 30, 2023
4 checks passed
@rsdmike rsdmike deleted the redirectionXmlStructs branch October 30, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-primrose matt-primrose matt-primrose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zaidusmani26 @matt-primrose @rsdmike