refactor: checks the return value of the amt response (#223)

pkg/wsman/amt/setupandconfiguration/service.go

@@ -11,11 +11,13 @@ import (
 	"encoding/xml"
 	"errors"
 	"fmt"
+	"strconv"
 
 	"github.com/google/uuid"
 	"github.com/open-amt-cloud-toolkit/go-wsman-messages/v2/internal/message"
 	"github.com/open-amt-cloud-toolkit/go-wsman-messages/v2/pkg/wsman/amt/methods"
 	"github.com/open-amt-cloud-toolkit/go-wsman-messages/v2/pkg/wsman/client"
+	"github.com/open-amt-cloud-toolkit/go-wsman-messages/v2/pkg/wsman/common"
 )
 
 // DecodeUUID formats the returned AMT base64 encoded UUID into a human readable UUID
@@ -169,6 +171,7 @@ func (s Service) CommitChanges() (response Response, err error) {
 	if err != nil {
 		return
 	}
+	err = checkReturnValue(response.Body.SetMEBxPassword_OUTPUT.ReturnValue, "Commit Changes")
 	return
 }
 
@@ -239,6 +242,7 @@ func (s Service) SetMEBXPassword(password string) (response Response, err error)
 	if err != nil {
 		return
 	}
+	err = checkReturnValue(response.Body.SetMEBxPassword_OUTPUT.ReturnValue, "MEBx Password")
 	return
 }
 
@@ -282,3 +286,16 @@ func (s Service) Unprovision(provisioningMode ProvisioningModeValue) (response R
 
 	return
 }
+
+func checkReturnValue(rc int, item string) (err error) {
+	if rc != common.PT_STATUS_SUCCESS {
+		if rc == common.PT_STATUS_DUPLICATE {
+			return errors.New(item + " already exists and must be removed before continuing")
+		} else if rc == common.PT_STATUS_INVALID_CERT {
+			return errors.New(item + " is invalid")
+		} else {
+			return errors.New(item + " non-zero return code: " + strconv.Itoa(rc))
+		}
+	}
+	return nil
+}