doc(dns): more precise stdlib resolver naming #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request documents changes implemented while developing the [email protected] prototype (aka long term evolution).
bassosimone
changed the title
This set of commits address recent feedback by @FedericoCeratto
bassosimone
added a commit
to ooni/probe-cli
that referenced
this pull request
Aug 27, 2022
See what we documented at ooni/spec#257 Reference issue: ooni/probe#2238 While there, bump [email protected] version because this change has an impact onto the generated data format.
bassosimone
changed the title
bassosimone
commented
Aug 27, 2022
bassosimone
commented
Aug 27, 2022
bassosimone
commented
Aug 27, 2022
bassosimone
commented
Aug 27, 2022
bassosimone
commented
Aug 27, 2022
bassosimone
commented
Aug 27, 2022
bassosimone
commented
Aug 27, 2022
bassosimone
commented
Aug 27, 2022
bassosimone
commented
Aug 27, 2022
bassosimone
commented
Aug 27, 2022
bassosimone
added a commit
to ooni/probe-cli
that referenced
this pull request
Aug 27, 2022
See what we documented at ooni/spec#257 Reference issue: ooni/probe#2238 See also the related ooni/spec PR: ooni/spec#257 See also ooni/probe#2237 While there, bump [email protected] version because this change has an impact onto the generated data format. The drop in coverage is unavoidable because we've written some tests for `measurex` to ensure we deal with DNS resolvers and transport names correctly depending on the splitting policy we use. (However, `measurex` is only used for the `tor` experiment and, per the step-by-step design document, new experiments should use `measurexlite` instead, so this is hopefully fine(TM).) While there, fix a broken integration test that does not run in `-short` mode.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This pull request documents more precise stdlib resolver naming that will benefit [email protected].
See ooni/probe#2238, ooni/probe#2237, ooni/probe-cli#885.
While there, fix the template for new PRs.