Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts-018-whatsapp.md: ack CIDR logic being broken #178

Merged
merged 3 commits into from
Feb 21, 2020
Merged

ts-018-whatsapp.md: ack CIDR logic being broken #178

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd5c179
ts-018-whatsapp.md: ack CIDR logic being broken
bassosimone Feb 20, 2020
b72fc1c
Update ts-018-whatsapp.md
bassosimone Feb 20, 2020
2f97a1c
Update ts-018-whatsapp.md
bassosimone Feb 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions nettests/ts-018-whatsapp.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ consider the endpoint to be blocked and write in the report:
}
```

Since 2020-02-17, this consistency check has started failing consistently as
documented in the bugs section at the end of this document.

For every IP, both consistent and inconsistent, we then try to establish a TCP session to port `443`
and `5222`.

Expand Down Expand Up @@ -547,3 +550,14 @@ The meaning of the various keys is described in the above section.
"test_version": "0.5.0"
}
```

## Bugs

Since 2020-02-17, the heristics for checking whether a netblock belongs to
WhatsApp as described in version 2016-10-25-001 of this specification is
fundamentally broken (see [ooni/probe-engine#341](
https://github.com/ooni/probe-engine/issues/341)). This issue affected
ooni/probe-legacy <= 2.3.0, ooni/probe-ios <= 2.2.0, ooni/probe-android
<= 2.2.0. The `test_version` was 0.6.0 for ooni/probe-legacy and 0.6.1
for the mobile apps. Since Measurement Kit 0.10.10 (`test_version`
0.7.0) we will completely disable such check.