Skip to content

Commit

Permalink
whatsapp: improve spec to reduce false positives (#197)
Browse files Browse the repository at this point in the history
Specifically, say that WhatsApp web is reachable over HTTPS regardless
of the HTTP status code and that over HTTP we're happy if we get a
redirect to the correct location.

This is part of ooni/probe-engine#740.

While there, remove the all endpoints option. We should test all the
endpoints to make a better statement on whether it's blocked.

(A single endpoint down is, in fact, a false positive.)

While there, explicitly say that the CIDR check is gone for good,
since it has not been working for quite some time now.

While there, mention all the parent data formats and specify the
toplevel structure in a more strict way.
  • Loading branch information
bassosimone authored Jul 9, 2020
1 parent ce606c0 commit 0c2e2d6
Show file tree
Hide file tree
Showing 2 changed files with 1,018 additions and 397 deletions.
6 changes: 6 additions & 0 deletions data-formats/df-007-errors.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@ is not flagged, it means that it's used by all the three products.

- `"http_request_failed"` (MK, PE): HTTP request did not return a successful response code

- `"http_unexpected_redirect_url"` (PE): we expected a specific redirect URL and
instead we saw either no redirect URL or a different redirect URL

- `"http_unexpected_status_code"` (PE): we did not expected to see this status
code (e.g. we expected a redirection and saw something else)

- `"interrupted"` (PE): the user interrupted us by cancelling the context

- `"response_never_received"` (PL): [t.w._newclient.ResponseNeverReceived](https://twistedmatrix.com/documents/15.4.0/api/twisted.web._newclient.ResponseNeverReceived.html)
Expand Down
Loading

0 comments on commit 0c2e2d6

Please sign in to comment.