Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show measurement #71

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Show measurement #71

merged 2 commits into from
Aug 20, 2024

Conversation

sdsantos
Copy link
Collaborator

Closes #45

@sdsantos sdsantos force-pushed the show-result branch 2 times, most recently from b0666b2 to bb77e24 Compare August 20, 2024 15:29
@sdsantos sdsantos requested a review from aanorbel August 20, 2024 15:52
Copy link
Member

@aanorbel aanorbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont particularly agree with adding a webview if opening on device browser is just as effective.

Base automatically changed from show-result to main August 20, 2024 16:23
@sdsantos sdsantos requested a review from aanorbel August 20, 2024 17:05
Copy link
Member

@aanorbel aanorbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@sdsantos sdsantos merged commit 7aedcad into main Aug 20, 2024
7 checks passed
@sdsantos sdsantos deleted the show-measurement branch August 20, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Results: See measurement (webview)
2 participants