Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add network type finder for iOS #49

Merged
merged 4 commits into from
Aug 14, 2024
Merged

feat: add network type finder for iOS #49

merged 4 commits into from
Aug 14, 2024

Conversation

aanorbel
Copy link
Member

@aanorbel aanorbel commented Aug 8, 2024

Closes: #33

@aanorbel aanorbel marked this pull request as ready for review August 8, 2024 21:39
Base automatically changed from issues/25-ios-bug to main August 12, 2024 09:47
return NetworkTypeUnknown(value: "")
}
}
return NetworkTypeUnknown(value: "")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this one be NoInternet?

@aanorbel aanorbel merged commit 7f8bff9 into main Aug 14, 2024
7 checks passed
@aanorbel aanorbel deleted the issues/33 branch August 22, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NetworkTypeFinder: iOS Implementation
2 participants