Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish Engine SDK #36

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Finish Engine SDK #36

merged 2 commits into from
Aug 6, 2024

Conversation

sdsantos
Copy link
Collaborator

@sdsantos sdsantos commented Aug 5, 2024 •
edited
Loading

  • Don't expose engine settings to the app. They are build internally using few arguments and the preferences.
  • Pass the background dispatcher as an argument so it's easier to test the Engine

TODO

  • Tests
  • Resubmit Results

Closes #18

@sdsantos sdsantos requested a review from aanorbel August 5, 2024 17:19
aanorbel
aanorbel approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@aanorbel aanorbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@sdsantos sdsantos merged commit 951882a into main Aug 6, 2024
7 checks passed
@sdsantos sdsantos deleted the finish-engine branch August 6, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanorbel aanorbel aanorbel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-platform: Implement Engine API
2 participants
@sdsantos @aanorbel