Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test options #313

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Improve test options #313

merged 3 commits into from
Nov 27, 2024

Conversation

sdsantos
Copy link
Collaborator

Closes #282

Other translations also need to be updated.

@sdsantos sdsantos requested a review from aanorbel November 26, 2024 18:12
Copy link
Member

@aanorbel aanorbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳 Update translation keys and fix failing build

Comment on lines 79 to 80
<string name="Settings_Websites_MaxRuntimeEnabled">Limit Websites test duration</string>
<string name="Settings_Websites_MaxRuntime">Maximum Websites test duration</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should preferably be new strings since there are existing translations we dont want these to be confused for.

@sdsantos sdsantos force-pushed the improve-test-options branch from f016615 to d8194cb Compare November 27, 2024 11:14
@sdsantos sdsantos merged commit 8e2afe9 into main Nov 27, 2024
6 checks passed
@sdsantos sdsantos deleted the improve-test-options branch November 27, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings: improve usability of test options
2 participants