Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test reporting improvements #305

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Test reporting improvements #305

merged 3 commits into from
Nov 26, 2024

Conversation

sdsantos
Copy link
Collaborator

  • Don't report ResolverLookupFailures
  • Skip reporting StartupFailures if the user stopped/cancelled the test
  • Report ResolverLookupFailure, StartupFailures and BugJsonDump always using an exception, to see if they are grouped together on Sentry
  • Revert debug urls back to dev

@sdsantos sdsantos requested a review from aanorbel November 25, 2024 15:17
aanorbel
aanorbel approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@aanorbel aanorbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@sdsantos sdsantos merged commit 9393774 into main Nov 26, 2024
6 checks passed
@sdsantos sdsantos deleted the resolver-lookup-failure branch November 26, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanorbel aanorbel aanorbel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdsantos @aanorbel