show website animation and colors in RunningScreen #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdsantos
approved these changes
Nov 19, 2024
| if (!inputs.isNullOrEmpty() || test !is TestType.WebConnectivity) return inputs | ||
|
|
||
| setRunBackgroundState { |
There was a problem hiding this comment.
This sort of assumes that the Websites descriptor will always be the first one to run. It's true for now, but we need to be careful.
There was a problem hiding this comment.
This does not assume for the most part. If the website is not the first to run, the code above exits before it get here.
There was a problem hiding this comment.
We are looping through all descriptors and tests. There's no check if it's the first one I believe.
There was a problem hiding this comment.
Here we are looping through and returning inputs or downloading URLs.
- the code exits if the test has inputs or its not web connectivity.
- when the condition to download URLs is met, the new state is emitted with the current test that is performing the action.
- I can clear the descriptor and test type post-download if that makes it better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #274