Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide tap results after tap #287

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Hide tap results after tap #287

merged 2 commits into from
Nov 20, 2024

Conversation

sdsantos
Copy link
Collaborator

Closes #281

@sdsantos sdsantos requested a review from aanorbel November 18, 2024 18:50
aanorbel
aanorbel requested changes Nov 19, 2024
View reviewed changes
Copy link
Member

@aanorbel aanorbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 When the results is also opened from the bottom navigation, when the view is displayed, it should be dismissed.

@sdsantos sdsantos requested a review from aanorbel November 19, 2024 11:45
aanorbel
aanorbel approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@aanorbel aanorbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@sdsantos sdsantos merged commit da08a88 into main Nov 20, 2024
7 checks passed
@sdsantos sdsantos deleted the tap-results-once branch November 20, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanorbel aanorbel aanorbel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dashboard: hide "Tap to view results" after usage
2 participants
@sdsantos @aanorbel