Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification: Handle stopping state and disable dismiss #231

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Notification: Handle stopping state and disable dismiss #231

merged 1 commit into from
Oct 30, 2024

Conversation

sdsantos
Copy link
Collaborator

Closes #226

@sdsantos sdsantos requested a review from aanorbel October 29, 2024 16:23
aanorbel
aanorbel approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@aanorbel aanorbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@sdsantos sdsantos merged commit 1ca3624 into main Oct 30, 2024
7 checks passed
@sdsantos sdsantos deleted the notification-stop-and-dismiss branch October 30, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanorbel aanorbel aanorbel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test Notification: handle stopping test state
2 participants
@sdsantos @aanorbel