Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Delete All Measurements #185

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

sarathms
Copy link
Contributor

@sarathms sarathms commented Nov 20, 2020

@sarathms sarathms requested a review from hellais November 20, 2020 08:31
@sarathms sarathms self-assigned this Nov 20, 2020
@sarathms
Copy link
Contributor Author

Progress so far

image

image

Yet to align with the mockups in ooni/probe#1267

  • button styling
  • Calculating size of the correct directory ${OONI_HOME}/msmts/
  • Confirmation dialog styling

@hellais
Copy link
Member

hellais commented Nov 20, 2020

Let's just just use the same style as the EDIT button above for the "Delete all measurements" button

@sarathms
Copy link
Contributor Author

  1. What is the styling decision behind the Delete All button? Is it a link or a differently styled <Button hollow>
    This was already answered above.
  2. When the user performs the action, I think the expectation is to see a zero value size as a result. This is possible only if we calculate the size of ${OONI_HOME}/msmts. This seems like the logical thing to do. Let me know if there is something else also to consider.

@hellais
Copy link
Member

hellais commented Nov 27, 2020

Let's align the copy to the mobile app.

Instead of "Total storage used" it should read:
"Storage used" and the button below should read "Clear uploaded"

@hellais
Copy link
Member

hellais commented Nov 27, 2020

When the user performs the action, I think the expectation is to see a zero value size as a result. This is possible only if we calculate the size of ${OONI_HOME}/msmts. This seems like the logical thing to do. Let me know if there is something else also to consider.

If we can do this and obtain a consistent result, the config file is regenerated properly and the DB will be re-created as expected, then go for it.

However there is the issue that we are doing it only for uploaded measurements, because I believe we don't yet have support for checking which are the uploaded measurements and re-uploadeding the unuploaded.

I think we can do this incrementally and in the first iteration not care about the total not going to zero, but accept that, if there are some un-uploaded measurements for it to be non-zero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement measurement deletion feature
2 participants