Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dnscheck default input test #1669

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: dnscheck default input test #1669

merged 1 commit into from
Nov 25, 2024

Conversation

DecFox
Copy link
Contributor

@DecFox DecFox commented Nov 25, 2024

Checklist

  • I have read the contribution guidelines
  • reference issue for this pull request:
  • if you changed anything related to how experiments work and you need to reflect these changes in the ooni/spec repository, please link to the related ooni/spec pull request:
  • if you changed code inside an experiment, make sure you bump its version number

Description

This fixes the dnscheck default input test observed failing here: https://github.com/ooni/probe-cli/actions/runs/12016869033/job/33497976676#step:5:536.

@DecFox DecFox requested a review from hellais as a code owner November 25, 2024 19:20
@DecFox DecFox merged commit 159d8b3 into master Nov 25, 2024
14 of 18 checks passed
@DecFox DecFox deleted the fix/dnscheck-test branch November 25, 2024 19:36
@BrewTestBot BrewTestBot mentioned this pull request Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellais hellais Awaiting requested review from hellais hellais is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DecFox