Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dnscheck): add resolver urls for trust anchor change testing #1667

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DecFox
Copy link
Contributor

@DecFox DecFox commented Nov 25, 2024

Checklist

  • I have read the contribution guidelines
  • reference issue for this pull request:
  • if you changed anything related to how experiments work and you need to reflect these changes in the ooni/spec repository, please link to the related ooni/spec pull request:
  • if you changed code inside an experiment, make sure you bump its version number

Description

This diff adds support for measuring using the system resolver and also adds resolver urls allowing us to test the trust anchor change.

@DecFox DecFox requested a review from hellais as a code owner November 25, 2024 12:02
@hellais
Copy link
Member

hellais commented Nov 25, 2024

I tested this branch both with how it's setup now and by replacing the address definitions with system://, however I don't think it's working as intended.

The fact that dnscheck has this two step bootstrap and lookup process, means that it's interpreting the input definitions as the configuration vectors for a DoH/DoT server.

I think that in order to get this work well we should spend a bit more time refining the test, so I suggest we defer merging this to a future probe-engine release and in the interim we just add the URLs to web_connectivity.

Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should defer this to a future release.

@DecFox DecFox marked this pull request as draft November 26, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants