refactor(oonimkall): expose the session close call #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanorbel
pushed a commit
to ooni/probe-android
that referenced
this pull request
Nov 29, 2024
Fixes ooni/probe#2810 ## Proposed Changes - Exposes the `close` function for the engine session - Invokes the `close` function while downloading urls for webconnectivity to ensure the running psiphon tunnel (and engine session) is closed before the experiment run - Changes in engine api surface: ooni/probe-cli#1657
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This diff exposes the
Session.Closecall for the geoip session we initialize in the mobile app. This is required to close the circumvention tunnel before we use start another tunnel as part of the async tasks to run the experiments.