refactor(httpapi): logger belongs to endpoint #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff changes httpapi Endpoint and Descriptor such that the logger field is part of the Endpoint rather than Descriptor. This changes makes sense because the logger to use should be the same for every API call. What matters, instead, is whether to log bodies, which remains a property of the API Descriptor. While I authored this diff originally as part of the work done in #997, it seems it's required in #1002 as well. Hence, the reference issue is ooni/probe#2379.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This diff changes httpapi Endpoint and Descriptor such that the logger field is part of the Endpoint rather than Descriptor.
This changes makes sense because the logger to use should be the same for every API call. What matters, instead, is whether to log bodies, which remains a property of the API Descriptor.
While I authored this diff originally as part of the work done in #997, it seems it's required in #1002 as well.
Hence, the reference issue is ooni/probe#2379.