Skip to content

Commit

Permalink
x
Browse files Browse the repository at this point in the history
  • Loading branch information
bassosimone committed Sep 14, 2023
1 parent 377ed81 commit f5509a1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions internal/tutorial/netxlite/chapter07/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,10 @@ a single request using the given TLS conn.
uses a cleartext TCP connection. In the next chapter we'll
see how to do the same using QUIC.)
```Go

TODO(https://github.com/ooni/probe/issues/2534): here we're using the QUIRKY netxlite.NewHTTPTransport
function, but we can probably avoid using it, given that this code is
not using tracing and does not care about those quirks.
```Go
clnt := &http.Client{Transport: netxlite.NewHTTPTransport(
log.Log, netxlite.NewNullDialer(),
netxlite.NewSingleUseTLSDialer(conn.(netxlite.TLSConn)),
Expand Down
3 changes: 1 addition & 2 deletions internal/tutorial/netxlite/chapter07/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,10 @@ func main() {
// uses a cleartext TCP connection. In the next chapter we'll
// see how to do the same using QUIC.)
//
// ```Go
//
// TODO(https://github.com/ooni/probe/issues/2534): here we're using the QUIRKY netxlite.NewHTTPTransport
// function, but we can probably avoid using it, given that this code is
// not using tracing and does not care about those quirks.
// ```Go
clnt := &http.Client{Transport: netxlite.NewHTTPTransport(
log.Log, netxlite.NewNullDialer(),
netxlite.NewSingleUseTLSDialer(conn.(netxlite.TLSConn)),
Expand Down

0 comments on commit f5509a1

Please sign in to comment.