Skip to content

Commit

Permalink
fix: update Snowflake domain front (#1337)
Browse files Browse the repository at this point in the history
We're doing this due to problems with `cdn.sstatic.net`:

- https://lists.torproject.org/pipermail/anti-censorship-team/2023-September/000315.html
- https://forum.torproject.org/t/problems-with-snowflake-since-2023-09-20-broker-failure-unexpected-error-no-answer/9346

The reference issue is ooni/probe#2540.

While there, fix a typo in a test name.

---------

Co-authored-by: Simone Basso <[email protected]>
  • Loading branch information
cohosh and bassosimone authored Oct 6, 2023
1 parent ac1563b commit f29dbba
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion internal/experiment/torsf/integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import (
)

func TestRunWithExistingTor(t *testing.T) {
t.Skip("https://github.com/ooni/probe/issues/2540")
if testing.Short() {
t.Skip("skip test in short mode")
}
Expand Down
2 changes: 1 addition & 1 deletion internal/ptx/snowflake.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func (d *snowflakeRendezvousMethodDomainFronting) BrokerURL() string {
}

func (d *snowflakeRendezvousMethodDomainFronting) FrontDomain() string {
return "cdn.sstatic.net"
return "foursquare.com"
}

// NewSnowflakeRendezvousMethodAMP is a rendezvous method that
Expand Down
2 changes: 1 addition & 1 deletion internal/ptx/snowflake_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ func TestSnowflakeMethodDomainFronting(t *testing.T) {
if meth.BrokerURL() != brokerURL {
t.Fatal("invalid broker URL")
}
const frontDomain = "cdn.sstatic.net"
const frontDomain = "foursquare.com"
if meth.FrontDomain() != frontDomain {
t.Fatal("invalid front domain")
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/oonimkall/taskrunner_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -663,7 +663,7 @@ func TestTaskRunnerRun(t *testing.T) {
assertReducedEventsLike(t, expect, reduced)
})

t.Run("with succes and max runtime", func(t *testing.T) {
t.Run("with success and max runtime", func(t *testing.T) {
runner, emitter := newRunnerForTesting()
runner.settings.Inputs = []string{"a", "b", "c", "d"}
runner.settings.Options.MaxRuntime = 2
Expand Down

0 comments on commit f29dbba

Please sign in to comment.