Skip to content

Commit

Permalink
doc(webconnectivitylte): document "orig" HTTP analysis bug (#1422)
Browse files Browse the repository at this point in the history
  • Loading branch information
bassosimone authored Dec 1, 2023
1 parent a0d4b5c commit d84729d
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions internal/experiment/webconnectivitylte/analysishttpcore.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ func (tk *TestKeys) analysisHTTPToplevel(logger model.Logger) {
if len(tk.Requests) <= 0 {
return
}
// TODO(https://github.com/ooni/probe/issues/2641): this code is wrong
// with redirects because LTE only creates an HTTP request when it reaches
// the HTTP stage, so a previous redirect that is successful would cause
// this code to say we're good on the HTTP front, while we're not.
finalRequest := tk.Requests[0]
if finalRequest.Failure != nil {
tk.HTTPExperimentFailure = optional.Some(*finalRequest.Failure)
Expand Down

0 comments on commit d84729d

Please sign in to comment.