Skip to content

Commit

Permalink
Fix missing enabledByDefault in echcheck (#1655)
Browse files Browse the repository at this point in the history
Closes: ooni/probe#2807

## Checklist

- [ ] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [ ] reference issue for this pull request: <!-- add URL here -->
- [ ] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request: <!-- add URL here -->
- [ ] if you changed code inside an experiment, make sure you bump its
version number

<!-- Reminder: Location of the issue tracker:
https://github.com/ooni/probe -->

## Description

Please, insert here a more detailed description.
  • Loading branch information
hellais authored Oct 15, 2024
1 parent 9053991 commit a66b589
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
7 changes: 4 additions & 3 deletions internal/registry/echcheck.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,10 @@ func init() {
*config.(*echcheck.Config),
)
},
canonicalName: canonicalName,
config: &echcheck.Config{},
inputPolicy: model.InputOptional,
canonicalName: canonicalName,
config: &echcheck.Config{},
enabledByDefault: true,
inputPolicy: model.InputOptional,
}
}
}
4 changes: 1 addition & 3 deletions internal/registry/factory_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -593,9 +593,7 @@ func TestNewFactory(t *testing.T) {
inputPolicy: model.InputOrStaticDefault,
},
"echcheck": {
// Note: echcheck is not enabled by default because we just introduced it
// into 3.19.0-alpha, which makes it a relatively new experiment.
//enabledByDefault: false,
enabledByDefault: true,
inputPolicy: model.InputOptional,
},
"example": {
Expand Down

0 comments on commit a66b589

Please sign in to comment.